Allow Grain Integrations to update their own configs #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topocount
force-pushed
the
accounting
branch
from
19299b1
to
a96c7e9
Compare
topocount
force-pushed
the
config-updates
branch
from
748c5bf
to
6397af9
Compare
A grain integration might want to store some details within an instance, such as a smart contract address. This update allows arbitrary updates to a scoped object within the grain config file. Test Plan: Unit tests are provided at the grain integration interface. Integration testing will be demonstrated in the test instance using the merkle integration.
topocount
force-pushed
the
config-updates
branch
from
6397af9
to
4f23b36
Compare
blueridger
approved these changes
Dec 3, 2021
| @@ -46,6 +49,7 @@ export type IntegrationConfig = {| | |||
| // distributed funds via a configured integration | |||
| processDistributions: boolean, | |||
| currency: Currency, | |||
| integration: ?Object, | |||
There was a problem hiding this comment.
This is a confusing line. Maybe it wants to be renamed config or something?
There was a problem hiding this comment.
This is confusing in the context of the named IntegrationConfig type, but I don't think its confusing once within the context of an integration. Within an integration, its pretty clearly just reading its own configuration.
From within the context of a grain integration, we have
{
accounting,
currency,
processDisitributions,
integration
}
I'd be open to renaming it self but I think naming it config would more confusing and less descriptive in the alternative context, which needs to be much more approachable for devs looking to build their own integrations.
There was a problem hiding this comment.
I've added a comment to clarify what's going on instead.
topocount
added a commit
that referenced
this pull request
Dec 13, 2021
This reverts commit 5faa756.
topocount
added a commit
that referenced
this pull request
Dec 13, 2021
* Feature: Disable balance accounting in the ledger When utilizing an on chain grain integration, tracking account balances in the SourceCred ledger makes little sense. These changes disable balance accounting, while preserving the functionality key to SourceCred, which is tracking distributions across identities. While balances are no longer tracked, paid totals will continue to be. This feature, combined with Distribution execution tracking, narrows the scope of the ledgers focus to the state of distributions, and whether or not they have been executed outside of SourceCred. When account balance tracking is disabled, the following changes are made to ledger behavior: - all grain balances are zeroed out in mutable accounts tracked by the ledger - grain transfers are disabled - distributed grain is not added to a user's balance. the paid total is updated, however. Undistributed balances are tracked as a whole through the distribution tracking functionality added earlier. - identities without a relevant payout address will be deactivated - identities that have no relevant payout addresses configured cannot be activated. relevant means the external currency configured in the ledger's state. Test plan: Unit tests included * Allow Grain Integrations to update their own configs (#3271) A grain integration might want to store some details within an instance, such as a smart contract address. This update allows arbitrary updates to a scoped object within the grain config file. Test Plan: Unit tests are provided at the grain integration interface. Integration testing will be demonstrated in the test instance using the merkle integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A grain integration might want to store some details within an instance,
such as a smart contract address. This update allows arbitrary updates
to a scoped object within the grain config file.
Merge Plan
Test Plan:
Unit tests are provided at the grain integration interface. Integration
testing will be demonstrated in the test instance using the merkle
integration.