Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyInstaller to 4.3 #59

Closed
4 tasks done
maxbechtold opened this issue May 10, 2021 · 5 comments
Closed
4 tasks done

Update PyInstaller to 4.3 #59

maxbechtold opened this issue May 10, 2021 · 5 comments

Comments

@maxbechtold
Copy link
Collaborator

maxbechtold commented May 10, 2021

  • Include dependency
  • Update Sqlite3 if possible, specify its version (Readme?)
  • If required update license texts
  • Create a new maintenance release
@maxbechtold
Copy link
Collaborator Author

This should resolve #58

maxbechtold added a commit that referenced this issue May 10, 2021
@maxbechtold maxbechtold reopened this May 13, 2021
@maxbechtold
Copy link
Collaborator Author

Windows Defender just quarantined timerecord.exe which I updated to v2.10.4, this might be related to bundling with the new PyInstaller version. Reopening to investigate.

@maxbechtold
Copy link
Collaborator Author

maxbechtold commented May 14, 2021

MS Defender suddenly detects timerecord.exe as "Win32/Wacatac.B!ml" after bundling it with PyInstaller 4.3 (up to version 4.2, this never occurred iirc).

VirusTotal Findings also increased from 1 red flag to 15 red flags.

These false-positives seem to be inherent to the bundling and compression applied by PyInstaller, which is not at all dissimilar from methods used for concealing/obfuscating malware: pyinstaller/pyinstaller#4633 (comment)

There should be an additional point in the Troubleshooting section, and maybe check in a few weeks time if VirusTotal findings go down for v2.10.4. If not, we might need to go back to PyInstaller 4.2

@maxbechtold
Copy link
Collaborator Author

VirusTotal findings are back to 1 again: https://www.virustotal.com/gui/file/9f32054accb0ae7f7302d8d575510333ac578264462ebdf7ff209c47a190e3d7?nocache=1

A hint under "Troubleshooting" might not be a good idea - if MS Defender or VirusTotal discredit DRTR, what could convince a user otherwise? Plus, the findings might actually be true after all...

@maxbechtold
Copy link
Collaborator Author

Resolved with version 2.10.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant