Use latest nancy #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarthHater
reviewed
Feb 19, 2021
Comment on lines
+21
to
+24
| RUN apk add --no-cache curl | ||
|
|
||
| # required to get grep that supports -P option | ||
| RUN apk add --no-cache --upgrade grep |
There was a problem hiding this comment.
Not a major thing, but I think a good idea in general is to clean up after yourself, so maybe delete these packages unless they are needed?
There was a problem hiding this comment.
I think the upgraded grep must stick around because it is used later when running the docker image (to detect the "latest" version).
There was a problem hiding this comment.
Yeah that makes sense. I'd ditch curl maybe unless you need it? It's not a huge deal but I personally love leaving the environment as pristine as possible.
DarthHater
reviewed
Feb 19, 2021
DarthHater
reviewed
Feb 19, 2021
DarthHater
approved these changes
Feb 19, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration option:
nancyVersion.Valid values for this option are 'latest' or a specific version, like `v.1.0.6'.
Default value is 'latest'.
I chose to use a call to the github api to determine the latest version for a few reasons:
Fixes issue #3