New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version convention should fit PEP400 #252
Comments
The
|
|
Is this version style [1] I randomly google and get this https://pypi.anaconda.org/scipy-wheels-nightly/simple/numpy/ |
|
0.1.4+ does not fit PEP400, and mess up python dist release. This commit resolves the following warning message: /home/ubuntu/devenv/flavors/solvcon-01/usr/lib/python3.8/site-packages/setuptools/dist.py:507: UserWarning: The version specified ('0.1.4+') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details. Additionally, the naming convention style of `0.1.4.dev0` (using dot) is better than `0.1.4-dev0` (using dash). `0.1.4-dev0` is more consistent with `debian/changelog` we currently have. However, `0.1.4-dev0` will be normalized by `setuptools`to `0.1.4.dev0` and make our `test_from_package` confused about unexpected and inconsistent`${PKGNAME}`. Issue: solvcon#252
Please note pull request #253 does not fully fixes #249 , and simply one of the step to fix #249 in the first place. If we build SOLVCON build pull request #253 with [1] For example, https://github.com/tai271828/devenv/runs/4990806688?check_suite_focus=true |
This issue seems to be resolved by #253. Please reopen if I am wrong. |
When working on #249 and solvcon/devenv#98 , I realized that one of the CI failure of
test_from_package
https://github.com/solvcon/devenv/runs/4594808783?check_suite_focus=true is essentially caused by pypa/setuptools#2497 , and raising the following error message in the CI runs:The inconsistent and unexpected behavior of
python3 setup.py sdist
before/after the release of pypa/setuptools#2497 to make our CI handle the distribution tarball of SOLVCON confused withSOLVCON-0.1.4-
andSOLVCON-0.1.4+
.I would say
0.1.5
is fair since we did not bump the version for many years but the codebase changed a bit : )Additional Information
If we looked into the log of the CI failure https://github.com/solvcon/devenv/runs/4594808783?check_suite_focus=true#step:5:48147 , we would see that the build and function test of gas dynamic (Sodtube example) is runnable, but the
test_from_package
step failed. It means the build itself should be good, and the issue happens when making distributing.The text was updated successfully, but these errors were encountered: