Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stores' usage of __proto__ with Object.getPrototypeOf #1043

Merged
merged 1 commit into from Jun 7, 2022

Conversation

otonashixav
Copy link
Contributor

__proto__ is deprecated and Deno does not support it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2454571110

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.018%

Totals Coverage Status
Change from base Build 2430803736: 0.0%
Covered Lines: 1248
Relevant Lines: 1331

💛 - Coveralls

@ryansolid
Copy link
Member

Sigh, pretty sure I benched this one. Ok it is what it is.

@ryansolid ryansolid merged commit 5f929b0 into solidjs:main Jun 7, 2022
@otonashixav otonashixav deleted the chore-replace-deprecated-proto branch June 7, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants