Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct children of <Suspense> are not rendered reactively #1023

Closed
otonashixav opened this issue May 30, 2022 · 0 comments
Closed

Direct children of <Suspense> are not rendered reactively #1023

otonashixav opened this issue May 30, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@otonashixav
Copy link
Contributor

Reproduction: https://playground.solidjs.com/?hash=1323272100&version=1.4.1

Expected: The count should update when the button is clicked.

I think the solution is to use createMemo instead of untrack here: https://github.com/solidjs/solid/blob/main/packages/solid/src/render/Suspense.ts#L175
@ryansolid ryansolid added the enhancement New feature or request label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryansolid @otonashixav