Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3.js: add searchTransactionHistory: true to getSignatureStatus in confirmTransaction #32785

Closed
richardwu opened this issue Aug 10, 2023 · 2 comments
Labels
community Community contribution

Comments

@richardwu
Copy link

Problem

getSignatureStatus was added to confirmTransaction in #28290 for signatures that confirm before the onSignatureResult message arrives.

The issue is for older signatures that are no longer in the signatures cache, this will still hang because getSignatureStatus will not see the sig.

Proposed Solution

Add searchTransactionHistory: true (or expose it in confirmTransaciton) to the getSignatureStatus call.

@richardwu richardwu added the community Community contribution label Aug 10, 2023
@steveluscher
Copy link
Contributor

steveluscher commented Aug 10, 2023

@linuskendall, @brianlong, @mertimus: if web3.js added searchTransactionHistory to all getSignaturesStatuses calls made by the transaction confirmer, would your RPC explode, or would this be a non-event?

@CriesofCarrots
Copy link
Contributor

No longer in this repository

@CriesofCarrots CriesofCarrots closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

No branches or pull requests

3 participants