New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pretty print PublicKey objects in node and in the browser #29062
fix: pretty print PublicKey objects in node and in the browser #29062
Conversation
I'll have to double check that this doesn't narrow our browser compatibility too much (eg. for browsers that are missing |
Codecov Report
@@ Coverage Diff @@
## master #29062 +/- ##
=========================================
- Coverage 76.8% 76.7% -0.1%
=========================================
Files 55 55
Lines 3127 3141 +14
Branches 466 472 +6
=========================================
+ Hits 2403 2411 +8
- Misses 559 565 +6
Partials 165 165 |
Tested in React Native 0.70 with Hermes. Works fine. Symbol is supported all the way back to 2015 in major browsers. Shipping it. |
automerge label removed due to a CI failure |
Problem
console.log(publicKey)
is unreadable in Node.Summary of Changes
Add an object stringifier that includes the base58 string.
Test plan
Node
Browser
Fixes #20022.