Add confirmation status to ConfirmedSignatureInfo web3 response #28555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinmilt
reviewed
Oct 24, 2022
Co-authored-by: Austin Milt <austin.w.milt@gmail.com>
|
|
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
…se (solana-labs#28555) * Add confirmation status to ConfirmedSignatureInfo web3 response * Update web3.js/src/connection.ts Co-authored-by: Austin Milt <austin.w.milt@gmail.com> Co-authored-by: Austin Milt <austin.w.milt@gmail.com>
This was referenced Dec 20, 2022
This was referenced Dec 23, 2022
This was referenced Dec 28, 2022
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
…se (solana-labs#28555) * Add confirmation status to ConfirmedSignatureInfo web3 response * Update web3.js/src/connection.ts Co-authored-by: Austin Milt <austin.w.milt@gmail.com> Co-authored-by: Austin Milt <austin.w.milt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Web3.js
ConfirmedSignatureInfotype does not includeconfirmationStatus. This was corrected for documentation in PR#27264 but not added to the Connection class in web3.js.Summary of Changes
Updated
/solana/web3.js/src/connection.tsby addingconfirmationStatusas an optional value included inConfirmedSignatureInfotype:Fixes #27569