Handle already discarded packets in discard_excess_packets #22594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22594 +/- ##
=========================================
+ Coverage 81.1% 81.5% +0.4%
=========================================
Files 560 553 -7
Lines 151206 149655 -1551
=========================================
- Hits 122633 122047 -586
+ Misses 28573 27608 -965 |
behzadnouri
reviewed
Jan 20, 2022
sakridge
force-pushed
the
handle-discard
branch
from
fd17320
to
6c68f66
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
(cherry picked from commit 38b02bb) # Conflicts: # core/src/sigverify_stage.rs
mergify bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
(cherry picked from commit 38b02bb)
sakridge
added a commit
that referenced
this pull request
Jan 21, 2022
(cherry picked from commit 38b02bb)
sakridge
added a commit
that referenced
this pull request
Jan 21, 2022
(cherry picked from commit 38b02bb)
t-nelson
pushed a commit
that referenced
this pull request
Jan 21, 2022
(cherry picked from commit 38b02bb)
|
@Mergifyio backport v1.9 |
✅ Backports have been created
|
jstarry
pushed a commit
to jstarry/solana
that referenced
this pull request
May 3, 2022
|
I just rediscovered this bug on v1.9.. turns out the v1.9 backport was never merged so v1.9 hasn't been running this fix. New PR here: #24926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Packets with .discard() == true are considered as valid by discard_excess_packets, but they have already been dropped as dupes.
Summary of Changes
Don't consider discarded packets
Fixes #