Add PacketBatch packet_indexes stat #22564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalu
commented
Jan 18, 2022
segfaultdoc
approved these changes
Jan 18, 2022
added 2 commits
January 18, 2022 14:02
Codecov Report
@@ Coverage Diff @@
## master #22564 +/- ##
========================================
Coverage 81.1% 81.1%
========================================
Files 560 561 +1
Lines 151206 151297 +91
========================================
+ Hits 122633 122735 +102
+ Misses 28573 28562 -11 |
buffalu
commented
Jan 19, 2022
t-nelson
added
automerge
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2022
* collect stats on packet batch indicies * cleanup * cleanup * cleanup * change name (cherry picked from commit 6508822) # Conflicts: # core/src/banking_stage.rs
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2022
* collect stats on packet batch indicies * cleanup * cleanup * cleanup * change name (cherry picked from commit 6508822) # Conflicts: # core/src/banking_stage.rs
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
t-nelson
pushed a commit
that referenced
this pull request
Jan 19, 2022
* collect stats on packet batch indicies * cleanup * cleanup * cleanup * change name (cherry picked from commit 6508822) # Conflicts: # core/src/banking_stage.rs
t-nelson
pushed a commit
that referenced
this pull request
Jan 19, 2022
* collect stats on packet batch indicies * cleanup * cleanup * cleanup * change name (cherry picked from commit 6508822) # Conflicts: # core/src/banking_stage.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions
Problem
Suspect duplicates are screwing with max batch size for parallel execution.
Summary of Changes
Add metrics to collect data on packet_indexes.
Fixes #