Use VecDeque instead of Vec in sigverify stage #22538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
sigverify-rejection
branch
2 times, most recently
from
64fdc12
to
3c9599a
Compare
avoid bad performance of remove(0) for a single sender
sakridge
force-pushed
the
sigverify-rejection
branch
from
3c9599a
to
cba6506
Compare
buffalu
approved these changes
Jan 17, 2022
t-nelson
approved these changes
Jan 17, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2022
avoid bad performance of remove(0) for a single sender (cherry picked from commit 4944340) # Conflicts: # core/src/sigverify_stage.rs
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2022
avoid bad performance of remove(0) for a single sender (cherry picked from commit 4944340) # Conflicts: # core/src/sigverify_stage.rs
t-nelson
pushed a commit
that referenced
this pull request
Jan 17, 2022
avoid bad performance of remove(0) for a single sender (cherry picked from commit 4944340) # Conflicts: # core/src/sigverify_stage.rs
t-nelson
pushed a commit
that referenced
this pull request
Jan 17, 2022
avoid bad performance of remove(0) for a single sender (cherry picked from commit 4944340) # Conflicts: # core/src/sigverify_stage.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Vec has bad remove(0) performance.
Summary of Changes
Avoid bad performance of remove(0) for a single sender and use VecDeque instead.
Before:
After:
Fixes #