Remove per program timings from blockstore processor ledger replay #22370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22370 +/- ##
=========================================
- Coverage 81.0% 81.0% -0.1%
=========================================
Files 551 551
Lines 150041 150042 +1
=========================================
- Hits 121637 121616 -21
- Misses 28404 28426 +22 |
t-nelson
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
New vector of error timings grows unboundedly large during ledger replay because they are never coalesced.
Summary of Changes
The cost model is never updated in ledger replay anyways, so just clear the per program timings
Fixes #