Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes CowCachedExecutors (backport #22343) #22362

Merged
merged 2 commits into from Jan 7, 2022
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 7, 2022

This is an automatic backport of pull request #22343 done by Mergify.
Cherry-pick of c2389fc has failed:

On branch mergify/bp/v1.8/pr-22343
Your branch is up to date with 'origin/v1.8'.

You are currently cherry-picking commit c2389fc20.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   runtime/src/bank.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy-on-write semantics for cached executors can be implemented by a
simple Arc<CachedExecutors> as opposed to CowCachedExecutors:
https://github.com/solana-labs/solana/blob/f1e2598ba/runtime/src/bank.rs#L244-L247

This will also avoid the need for double locking as in:
https://github.com/solana-labs/solana/blob/f1e2598ba/runtime/src/bank.rs#L3490-L3491
https://github.com/solana-labs/solana/blob/f1e2598ba/runtime/src/bank.rs#L3525-L3526

(cherry picked from commit c2389fc)

# Conflicts:
#	runtime/src/bank.rs
@mergify mergify bot added conflicts automerge Merge this Pull Request automatically once CI passes labels Jan 7, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Jan 7, 2022

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Jan 7, 2022
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #22362 (7c6e8e8) into v1.8 (b30c726) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##             v1.8   #22362     +/-   ##
=========================================
- Coverage    81.5%    81.5%   -0.1%     
=========================================
  Files         459      459             
  Lines      130991   130967     -24     
=========================================
- Hits       106868   106823     -45     
- Misses      24123    24144     +21     

@mergify mergify bot merged commit 299a59f into v1.8 Jan 7, 2022
@mergify mergify bot deleted the mergify/bp/v1.8/pr-22343 branch January 7, 2022 16:18
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

This PR has been automatically locked since there has not been any activity in past 14 days after it was merged.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes conflicts locked PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant