Retain executor cache counts #22322
Merged
Retain executor cache counts #22322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a good incremental improvement to me, just needs tests |
t-nelson
previously approved these changes
Jan 6, 2022
runtime/src/bank.rs
Outdated
| if count < least { | ||
| least = count; | ||
| least_key = key; | ||
| let entry = if let Some(entry) = self.executors.get(pubkey) { |
There was a problem hiding this comment.
If we remove() instead of get() here, the entry can be reused and avoid the atomic ops
There was a problem hiding this comment.
Yes, much better, I also added a bit more cleanup possible due to your suggestion, thanks!
Codecov Report
@@ Coverage Diff @@
## master #22322 +/- ##
=========================================
- Coverage 81.1% 81.1% -0.1%
=========================================
Files 523 551 +28
Lines 146793 149606 +2813
=========================================
+ Hits 119067 121334 +2267
- Misses 27726 28272 +546 |
jstarry
approved these changes
Jan 6, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
(cherry picked from commit f1e2598)
mergify bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
(cherry picked from commit f1e2598)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When an executor cache entry is re-added its counts are cleared, wiping out its history even though it might be used frequently
Summary of Changes
Retain those counts
Fixes #