New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute metrics #22296
Merged
Merged
Add execute metrics #22296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22296 +/- ##
========================================
Coverage 81.0% 81.0%
========================================
Files 551 551
Lines 149617 149775 +158
========================================
+ Hits 121301 121454 +153
- Misses 28316 28321 +5 |
Two things:
|
jackcmay
reviewed
Jan 5, 2022
jackcmay
reviewed
Jan 5, 2022
jackcmay
reviewed
Jan 5, 2022
jackcmay
reviewed
Jan 5, 2022
You're right! I noticed some things were being measured that were unlikely to be expensive during a rebase. I'll re-evaluate the inherited commits
Will add. Jack wants it too, which is consensus enough for me 🙂 |
This was referenced Jan 6, 2022
mergify bot
added a commit
that referenced
this pull request
Jan 7, 2022
* move `ExecuteTimings` from `runtime::bank` to `program_runtime::timings` (cherry picked from commit 7d32909) # Conflicts: # core/Cargo.toml # ledger/Cargo.toml # programs/bpf/Cargo.lock * Add execute metrics (cherry picked from commit b25e4a2) * Add metrics for executor creation (cherry picked from commit 848b6df) * Add helper macro for `AddAssign`ing with saturating arithmetic (cherry picked from commit deb9344) * Use saturating_add_assign macro (cherry picked from commit 72fc609) * Consolidate process instruction execution timings to own struct (cherry picked from commit 390ef0f) Co-authored-by: Trent Nelson <trent@solana.com> Co-authored-by: Carl Lin <carl@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Execution is occasionally slow but cause is not captured in current metrics
Summary of Changes
Add more timings
Republish of #22043, since I apparently broke Github over there