adds methods to obtain shreds' erasure coded block and index #21325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21325 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 500 501 +1
Lines 140604 141003 +399
=========================================
+ Hits 114704 114981 +277
- Misses 25900 26022 +122 |
carllin
reviewed
Nov 19, 2021
ledger/src/shred.rs
Outdated
| let fec_set_index = self.common_header.fec_set_index; | ||
| let index = self.index().checked_sub(fec_set_index)? as usize; | ||
| if self.is_data() { | ||
| Some(index) |
There was a problem hiding this comment.
Should we also uphold this existing check from the current code:
if index >= num_data_shreds {
return Err(InvalidIndex);
}
There was a problem hiding this comment.
We don't know number of data shreds here, and I don't want to pass it in as a function argument (or check it inside Shredder) because then that would leak out implementation details.
The goal of this commit was to encapsulate and hide the implementation details of erasure coding indices.
I think it is fine not to check for it because data reconstruct from codes will error out anyways.
The check was only added recently in #21082
and is not released yet.
behzadnouri
force-pushed
the
erasure-block
branch
from
e65c078
to
a08b17e
Compare
carllin
approved these changes
Nov 19, 2021
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…olana-labs#21325)" This reverts commit b267586.
mergify bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
(cherry picked from commit 7da2df7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Working towards encapsulating erasure coding scheme inside shreds in order to simplify upcoming changes and not to leak implementation details.
Summary of Changes
.drain.