onSignature infinite loop

[crispheaney]

Overview

We use onSignature to listen for tx confirmations

Steps to reproduce

If you have a bot that is sending a lot of tx, especially when network is congested, it is more likely to happen. I think rpc needs to reject initial subscribe.

Description of bug

Calling signatureSubscribe with _rpcWebSocket.call throws an error, it's caught and then _updateSubscription recursively calls itself again, causing an infinite loop.

Attaching screenshot of the logs we're seeing

[steveluscher]

What version of web3.js?

See also:

• socket hang up #1426
• web3.js: _updateSubscriptions running in infinite recursion, crashing developed app #1177
• web3.js: after fixing issue #25133 app still can freeze solana#25322
• fix: reduce Connection keep-alive timeout to 1 second fewer than the Solana RPC's keep-alive timeout solana#29130

But most importantly

• [web3.js] Infinite recursion caused by _updateSubscriptions #1106
• Clear the reconnection timer when the socket reconnects for any reason elpheria/rpc-websockets#138

[steveluscher]

More importantly, though, let's get you on the new version of web3.js!

Start here: https://www.youtube.com/watch?v=JUJtAPhES5g
More reading: https://github.com/solana-labs/solana-web3.js/blob/master/packages/library/README.md

If you're down, I will give you 1:1 support to upgrade your transaction making/confirming code.

[github-actions]

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.