Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integers beyond parsed: info: are always bigint #1828

Open
buffalojoec opened this issue Nov 11, 2023 · 3 comments
Open

Integers beyond parsed: info: are always bigint #1828

buffalojoec opened this issue Nov 11, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@buffalojoec
Copy link
Collaborator

buffalojoec commented Nov 11, 2023

Description

Since we haven't added any of the JSON-parsed instruction types to the typespec in @solana/rpc-core, any fields that are part of a JSON-parsed transaction instruction default to bigint over number, due to our response processor.

Steps to reproduce

Find a transaction that has a JSON-parsed instruction that uses an integer value that should not be cast to bigint - such as decimals.

You'll see that getTransaction or getBlock will convert this value into a bigint.

@buffalojoec buffalojoec added the bug Something isn't working label Nov 11, 2023
@buffalojoec
Copy link
Collaborator Author

Perhaps we just need to fully update the "allowed numeric values" maps to be completely aligned with all jsonParsed types supported by the RPC.

@steveluscher
Copy link
Collaborator

I can't remember, did we do this?

@buffalojoec
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants