Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token-cli: Run tests in batches #3396

Merged
merged 1 commit into from Jul 29, 2022

Conversation

joncinque
Copy link
Contributor

Problem

The token cli tests have become flaky, as an outcome of running so many test validators in parallel.

Solution

Run the tests in two big batches using serial_test::parallel. If needed, we can instead do it in three batches. This seemed like an easy solution, but does require setting a new parallel for each test added, which could be annoying. Alternatives are welcome!

@CriesofCarrots
Copy link
Contributor

Are there test assumptions we could change to make the tests not interfere with each other instead?
I've no strong opposition to this, but curious which approach would be less brittle.

@joncinque
Copy link
Contributor Author

joncinque commented Jul 29, 2022

The tests don't really interfere with each other, it's just depleting resources on the system running it, which causes errors. An alternative is bundling the tests together so each one tests more conditions, but that could still break in the future if we add too many tests.

@CriesofCarrots
Copy link
Contributor

Ohh, that kind of flaky. Okay, let's roll with this, then

@joncinque joncinque merged commit 80b8ff3 into solana-labs:master Jul 29, 2022
@joncinque joncinque deleted the tkcli-serialize branch July 29, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants