token-2022: Zeroize account data on close #2764
Conversation
|
|
||
| /// Checks two pubkeys for equality in a computationally cheap way using | ||
| /// `sol_memcmp` | ||
| pub fn cmp_pubkeys(a: &Pubkey, b: &Pubkey) -> bool { |
There was a problem hiding this comment.
Perhaps we could manually implement PartialEq for Pubkey to make this optimization available to all Rust programs automatically
There was a problem hiding this comment.
Definitely. I want to wait until the memcmp costs are sorted out and be sure that it's cheaper before making it the default behavior.
token/program-2022/src/processor.rs
Outdated
| @@ -297,6 +298,11 @@ impl Processor { | |||
| )?, | |||
| }; | |||
|
|
|||
| if self_transfer || amount == 0 { | |||
There was a problem hiding this comment.
wdyt about unconditionally checking as belts and suspenders? Slightly more compute for the false case seems to be the only downside
There was a problem hiding this comment.
It depends on how sensitive we want to be about raising compute costs. I'm a bit worried that the extensions will make things more expensive, and these owner checks are already quite pedantic.
How about this: we remove the checks now, and when we're ready to release, we revisit compute costs and see if the savings are worth it at that point?
token/program-2022/src/processor.rs
Outdated
| @@ -574,6 +580,11 @@ impl Processor { | |||
| COption::None => return Err(TokenError::FixedSupply.into()), | |||
| } | |||
|
|
|||
| if amount == 0 { | |||
There was a problem hiding this comment.
Same here, unconditionally check?
token/program-2022/src/processor.rs
Outdated
| @@ -658,6 +669,11 @@ impl Processor { | |||
| )?, | |||
| } | |||
|
|
|||
| if amount == 0 { | |||
This the token-2022 version of #2763
Problem
Closing accounts doesn't null out all the data.
Solution
Zero out all data on account close.
Differences with the non-2022 version:
check_program_accountinstead of the other owner checkcmp_pubkeysrefactored into lib.rssol_memseton close sets the entiredata.len()to 0, and notAccount:::LEN