Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stake-pool-cli: Sign messages before checking fee #2759

Merged
merged 1 commit into from Jan 20, 2022

Conversation

joncinque
Copy link
Contributor

Problem

get_fee_for_message is failing because the message is not signed, so there's no blockhash in the message yet.

Solution

Sign the messages before getting the fee

@joncinque joncinque merged commit 2e03106 into solana-labs:master Jan 20, 2022
@joncinque joncinque deleted the sp-cli-bh branch January 20, 2022 13:36
@t-nelson
Copy link
Contributor

Signing something that may not be submitted makes my skin crawl. Consider Message::new_with_blockhash

@joncinque
Copy link
Contributor Author

Oh that's great, thanks for noticing that! I assumed there was no way to attach a blockhash to a message without signing, but in all honestly, I didn't even check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants