You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BTW, I don't find how the JIT emit_shift does src%32 in the X64 code for rbpf shl_reg instruction (sorry, I am not familiar with x86 ISA if this is a stupid question).
The text was updated successfully, but these errors were encountered:
Is there a specific need for this?
Generally we can't just remove verification steps and add them to the JIT only, because then the Interpreter and JIT could disagree.
Hello Lichtso,
The interpreter has a wrapping semantics, e.g. LSH32_IMM does imm%32, so rbpf could do the same wrapping operation imm%32 during the JIT process. In this case, the shift verification step could be removed.
The current way is OK: someone may confuse that the shift verification step in verifier and the wrapping semantics in interpreter are overlapping.
Best,
Shenghao
Hi,
could we remove all check_imm_shift from the verifier, or do this checking during JIT's emit_shift?
For the interpreter, the
wrapping_shl
has ensuredimm%64
orimm%32
.BTW, I don't find how the JIT emit_shift does
src%32
in the X64 code for rbpf shl_reg instruction (sorry, I am not familiar with x86 ISA if this is a stupid question).The text was updated successfully, but these errors were encountered: