Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page data should be sourced from local cache when pressing back button (if not the entire page from the bfcache) #297

Open
steveluscher opened this issue Sep 22, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@steveluscher
Copy link
Collaborator

Describe the bug
When you click back to visit a page that you have already been to, we fetch data anew. This contributes to folks blowing the rate limit on the RPC and getting 429 HTTP errors.

To Reproduce
Steps to reproduce the behavior:

  1. Visit an account page
  2. Click on a transaction
  3. Click the back button

Expected behavior
No network requests should be made when you return to the account page in a short enough amount of time.

Additional context
This is probably a massive amount of work that should start with the complete reimagining of how we fetch data in the Explorer. All of the things that next.js gives you for free in terms of caching, we don't get, and we need to examine what it is about our architecture that opts us out of that default.

@steveluscher steveluscher added the bug Something isn't working label Sep 22, 2023
@steveluscher steveluscher assigned ngundotra and unassigned ngundotra Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants