Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish tests produce different checksums on windows #883

Closed
maciektr opened this issue Nov 8, 2023 · 1 comment · Fixed by #898
Closed

Publish tests produce different checksums on windows #883

maciektr opened this issue Nov 8, 2023 · 1 comment · Fixed by #898
Assignees
Labels
bug Something isn't working

Comments

@maciektr
Copy link
Contributor

maciektr commented Nov 8, 2023

No description provided.

@maciektr maciektr added the bug Something isn't working label Nov 8, 2023
maciektr added a commit that referenced this issue Nov 8, 2023
commit-id:1bcbe058
maciektr added a commit that referenced this issue Nov 8, 2023
commit-id:1bcbe058
maciektr added a commit that referenced this issue Nov 9, 2023
commit-id:1bcbe058
maciektr added a commit that referenced this issue Nov 9, 2023
commit-id:1bcbe058
github-merge-queue bot pushed a commit that referenced this issue Nov 9, 2023
maciektr added a commit that referenced this issue Nov 9, 2023
@maciektr maciektr self-assigned this Nov 10, 2023
@mkaput
Copy link
Member

mkaput commented Nov 13, 2023

This is caused by alexcrichton/tar-rs#341. We'll work around this on our side, and I'll submit a patch upstream.

mkaput added a commit that referenced this issue Nov 13, 2023
Although the `set_metadata_in_mode` call should set `mtime` to a
deterministic value, it fails to do so due to
alexcrichton/tar-rs#341. Also, the constant
value used there is funky and I do not feel convinced about its
stability. Therefore, we use our own `mtime` value explicitly here.

fix #883

Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2023
Although the `set_metadata_in_mode` call should set `mtime` to a
deterministic value, it fails to do so due to
alexcrichton/tar-rs#341. Also, the constant
value used there is funky and I do not feel convinced about its
stability. Therefore, we use our own `mtime` value explicitly here.

fix #883

Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants