Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taps often lost on Android real device + Fabric with header enabled #1975

Open
franksmule opened this issue Nov 20, 2023 · 5 comments
Open
Assignees
Labels
Platform: Android This issue is specific to Android Repro provided A reproduction with a snack or repo is provided

Comments

@franksmule
Copy link

Description

On a real android device, with fabric enabled, taps are often lost when Header is shown on Native Stack.

On an Android emulator, iOS and even using a tool such as scrcpy taps are always registered, using real device and manually tapping is very inconsistent. Have seen across multiple phones.

Steps to reproduce

  1. Checkout react-native-screens repo
  2. go to FabricExample folder
  3. Change App.js to code in linked snack repo.
  4. Run adb logcat | grep ReactNative
  5. Use on real android device - notice how logs do not print '1111' with every tap (inconsistent)
  6. Change headerShown to false logs WILL print with every tap

Snack or a link to a repository

https://snack.expo.dev/X06saJ53E

Screens version

main

React Native version

0.72.4

Platforms

Android

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Fabric (New Architecture)

Build type

Debug mode

Device

Real device

Device model

Nokia TA-1234

Acknowledgements

Yes

@github-actions github-actions bot added Platform: Android This issue is specific to Android Repro provided A reproduction with a snack or repo is provided labels Nov 20, 2023
@franksmule
Copy link
Author

To add some further findings:

TextInput has the same issue - taps are sometimes ignored, the input does not get focus and no keyboard.

If I use react-native-gesture-handler RectButton, TextInput they always work. The react-native imports have the intermittent issues.

@dviluk
Copy link

dviluk commented Dec 25, 2023

Same for me, you need to tap on the top half of the pressable component to trigger the event. I switched to @react-navigation/stack for now.

@dviluk
Copy link

dviluk commented Jan 23, 2024

Does some know what is causing this?

@grgmo
Copy link

grgmo commented Jan 24, 2024

similar issue we're seeing with native stack on react native 0.73.2 only on Fabric Android real device where tap seems to get lost and no onPress callback on header component.

@yosukapro
Copy link

Any solution found for this?

@kkafar kkafar self-assigned this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Android This issue is specific to Android Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

No branches or pull requests

5 participants