fix: potentially fix iOS 16.0 navigation header title bug #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
changed the title
DrOverbuild
added a commit
to DrOverbuild/react-native-screens
that referenced
this pull request
Oct 5, 2022
This was referenced Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Potentially fixes #1570 as suggested in comments.
I tested it on iOS 16.0 simulator & device - worked for me. However when I passed this solution to other team @software-mansion, it was reported back to me that there is no change (buggy behaviour still occurs).
I'm gonna merge this PR, as it introduces only
line-swapchange, which should not introduce any regression and potentially fixes the bug.NOTE: this issue seems to be already fixed internally by Apple as reported here.
Changes
Just moved
navitem.title = ...assignment belownavitem.titleView = ...one.Test code and steps to reproduce
See #1570
Checklist