Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load RNGestureHandlerModule lazily on iOS #3166

Merged
merged 2 commits into from Apr 11, 2022
Merged

Load RNGestureHandlerModule lazily on iOS #3166

merged 2 commits into from Apr 11, 2022

Conversation

j-piasecki
Copy link
Member

Description

At the time, the RNGestureHandlerModule is loaded when the createReanimatedModule method is called. This causes RCTBridge required dispatch_sync to load RNGestureHandlerModule. warning to appear. This PR changes it, so the module is loaded only the first time the setGestureState function is called.

Test code and steps to reproduce

Install react-native-reanimated and react-native-gesture-handler and check if the warning appears.

piaskowyk
piaskowyk approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piaskowyk piaskowyk merged commit d6c7304 into main Apr 11, 2022
@piaskowyk piaskowyk deleted the @jpiasecki/load-rngh-lazily branch April 11, 2022 19:14
@j-piasecki j-piasecki mentioned this pull request Apr 19, 2022
Closed
@billnbell
Copy link

Can we get this out in a release?

@sofiamoniz
Copy link

Hi! I still get the warning :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@j-piasecki @billnbell @sofiamoniz @piaskowyk