fix: Fix useAnimatedSensor return type
#3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremybarbet
reviewed
Apr 1, 2022
| @@ -501,10 +501,19 @@ declare module 'react-native-reanimated' { | |||
| interval: number; | |||
| }; | |||
|
|
|||
| export type AnimatedSensor = { | |||
There was a problem hiding this comment.
Any reason it's using a type rather than an interface?
react-native-reanimated.d.ts
Outdated
| sensor: SensorValue3D | SensorValueRotation | null; | ||
| unregister: () => void; | ||
| isAvailable: boolean; | ||
| config: { |
There was a problem hiding this comment.
Could be using the type defined above
Suggested change
| config: { | |
| config: SensorConfig |
|
@jeremybarbet I used exactly the same type decl as the internal file already uses. Ideally we want to keep both the same or have a single source of truth for it |
piaskowyk
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It returns
anynow.