Fix initialisation of NodesManager #1030
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgonet
force-pushed
the
@kuba/fix-NPE-in-nodes-manager
branch
from
7126191 to
fcafdc1
Compare
jgonet
commented
Jul 28, 2020
android/src/main/java/com/swmansion/reanimated/ReanimatedModule.java
Outdated
Show resolved
Hide resolved
jgonet
commented
Jul 29, 2020
android/src/main/java/com/swmansion/reanimated/NodesManager.java
Outdated
Show resolved
Hide resolved
jgonet
force-pushed
the
@kuba/fix-NPE-in-nodes-manager
branch
from
2227bdc to
02ae587
Compare
jgonet
added a commit
that referenced
this pull request
Aug 12, 2020
Previously, `NodesManager` registered (passing `this`) as an event listener before ending initialization in c-tor. `NodesManager` is created by `ReanimatedModule` (when calling `getNodesManager()` for the first time) on [UI thread](https://github.com/software-mansion/react-native-reanimated/blob/9af276693d136b712259fe9dd0126aee6c78bd4b/android/src/main/java/com/swmansion/reanimated/ReanimatedModule.java#L77-L80). When `onEventDispatch()` is called on non-UI thread it calls `startUpdatingOnAnimationFrame()`, which in turn uses `mChoreographerCallback`. `mChoreographerCallback` is initialised **after** listener is registered which causes NPE in React Choreographer's `postFrameCallback()` method after trying adding callback to the queue. Fixes #604. References: https://www.ibm.com/developerworks/java/library/j-jtp0618/index.html#2 https://stackoverflow.com/questions/25281301/what-exactly-are-the-dangers-of-passing-this-from-a-java-constructor
kmagiera
pushed a commit
that referenced
this pull request
Aug 13, 2020
Previously, `NodesManager` registered (passing `this`) as an event listener before ending initialization in c-tor. `NodesManager` is created by `ReanimatedModule` (when calling `getNodesManager()` for the first time) on [UI thread](https://github.com/software-mansion/react-native-reanimated/blob/9af276693d136b712259fe9dd0126aee6c78bd4b/android/src/main/java/com/swmansion/reanimated/ReanimatedModule.java#L77-L80). When `onEventDispatch()` is called on non-UI thread it calls `startUpdatingOnAnimationFrame()`, which in turn uses `mChoreographerCallback`. `mChoreographerCallback` is initialised **after** listener is registered which causes NPE in React Choreographer's `postFrameCallback()` method after trying adding callback to the queue. Fixes #604. References: https://www.ibm.com/developerworks/java/library/j-jtp0618/index.html#2 https://stackoverflow.com/questions/25281301/what-exactly-are-the-dangers-of-passing-this-from-a-java-constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
NodesManagerregistered (passing this) as an event listener before ending initialization in c-tor.NodesManageris created byReanimatedModule(when callinggetNodesManager()for the first time) on UI thread.When
onEventDispatch()is called on non-UI thread it callsstartUpdatingOnAnimationFrame(), which in turn usesmChoreographerCallback.mChoreographerCallbackis initialised after listener is registered which causes NPE in React Choreographer'spostFrameCallback()method after trying adding callback to the queue.Fixes #604.
References:
https://www.ibm.com/developerworks/java/library/j-jtp0618/index.html#2
https://stackoverflow.com/questions/25281301/what-exactly-are-the-dangers-of-passing-this-from-a-java-constructor