From 1a292f72cdd7cd17cbc42fd5b3ea0cfa2e3cbbf6 Mon Sep 17 00:00:00 2001 From: Tomek Zawadzki Date: Thu, 7 Apr 2022 13:13:03 +0200 Subject: [PATCH] Update ConfigHelper.ts (#3139) ## Description Currently, `opacity` prop is listed both in `UI_THREAD_PROPS_WHITELIST` and `NATIVE_THREAD_PROPS_WHITELIST`. However, when splitting props into three groups (namely: UI props, native props and JS props), we always search in the UI props set first, so effectively `opacity` is always animated like a UI prop (which is the expected behaviour). Nevertheless, we would like to avoid confusion by keeping these two sets disjoint, so this PR removes `opacity` from `NATIVE_THREAD_PROPS_WHITELIST`. ## Changes - Removed `opacity` from native props list ## Test code and steps to reproduce 1. Launch Example app 1. Open Olympic animation demo 1. See if opacity is properly animated ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes --- src/ConfigHelper.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ConfigHelper.ts b/src/ConfigHelper.ts index d25c89f7a03..d414622f663 100644 --- a/src/ConfigHelper.ts +++ b/src/ConfigHelper.ts @@ -78,7 +78,6 @@ let NATIVE_THREAD_PROPS_WHITELIST: Record = { borderTopLeftRadius: true, borderTopRightRadius: true, borderTopStartRadius: true, - opacity: true, elevation: true, fontSize: true, lineHeight: true,