New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TouchableHighlight initial 'underlayColor' value #595

Closed

paolospag opened this issue May 2, 2019 · 1 comment

Contributor

paolospag commented May 2, 2019 •

edited

@kmagiera
Fix unwanted initial value for underlayColor prop coded here:
https://github.com/kmagiera/react-native-gesture-handler/blob/master/touchables/TouchableHighlight.js#L30-L32

The correct code should be this:

...
  constructor(props) {
    super(props);
    this.state = {
      extraChildStyle: null,
      extraUnderlayStyle: null, // <-- this is the fix
    };
  }
...

I don't know how to create a correct pull request, so I created an issue.

The text was updated successfully, but these errors were encountered:

Contributor Author

paolospag commented May 9, 2019

PR for this:
#600

paolospag closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment