Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly show multi-line items belong to the tree #4

Open
epage opened this issue May 29, 2021 · 3 comments · May be fixed by #7
Open

Clearly show multi-line items belong to the tree #4

epage opened this issue May 29, 2021 · 3 comments · May be fixed by #7

Comments

@epage
Copy link
Contributor

epage commented May 29, 2021

assert_cmd uses predicates for its assertions and sometimes we are asserting on multi-line stdout and the output can be hard to parse, see assert-rs/assert_cmd#121

One idea we are exploring for this in predicates (see assert-rs/predicates-rs#106) is that we indent the entire block o content to the same level, ie under the tree. Ideally the branch would then flow within that indentation to the next item. This would require support from treeline to do.

@softprops
Copy link
Owner

Thanks for posting. This makes sense to me

@epage
Copy link
Contributor Author

epage commented May 31, 2021

Just want to check for understanding if you were expecting to go and implement this or if this was a greenlight for me.

@softprops
Copy link
Owner

Have at it!

epage added a commit to epage/treeline that referenced this issue Oct 6, 2021
In `assert_cmd`, we render assertion failures with treeline and
frequently have multi-line strings.  This will make it easier to see the
content.

Fixes softprops#4
@epage epage linked a pull request Oct 6, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants