Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release do 'not include valid file', but action passed anyway #54

Closed
kenorb opened this issue Jun 14, 2020 · 4 comments
Closed

Release do 'not include valid file', but action passed anyway #54

kenorb opened this issue Jun 14, 2020 · 4 comments

Comments

@kenorb
Copy link

kenorb commented Jun 14, 2020

I had the following error:

image

where the filename was invalid, however it didn't fail the action it-self.

I'm aware the filename was invalid, which was my mistake, however I guess the expected behaviour is to fail the step on such error, but instead it's green (which can be challenge to notice that something went wrong).

@bacongravy
Copy link
Contributor

I just ran into this issue today. I'd really like an option to have the action fail if it doesn't upload all of the specified files. Would you be open to a PR that either made that the default behavior, or added a "strict: true" parameter to enable it? (Changing the default behavior seems like a breaking change that would necessitate a major version bump.)

@softprops
Copy link
Owner

@bacongravy that'd be great.

I'd prefer a more intention. Revealing name though. Strict could mean anything. Perhaps something along the lines of fail_on_unmatched_asset or something?

Also it would also be a nice incremental improvement to emit a warning when a file is is not matched. These directives bubble up to a more integrated actions ui

@bacongravy
Copy link
Contributor

I put up PR #55 with a proposed change.

@softprops
Copy link
Owner

this has since been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants