Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The body of a release is overwritten with the content of body_path or body #362

Open
FirelightFlagboy opened this issue Jun 8, 2023 · 1 comment · May be fixed by #365
Open

The body of a release is overwritten with the content of body_path or body #362

FirelightFlagboy opened this issue Jun 8, 2023 · 1 comment · May be fixed by #365

Comments

@FirelightFlagboy
Copy link

FirelightFlagboy commented Jun 8, 2023 •
edited

Prelude

Hi,

I'm using this action to create a release.

I provide a body to that release that contain the check sum of the released artifacts.

Those check sum aren't stable since we don't have reproducible build at the moment.

Using body_path

That body come from a generated file that is provided within the field body_path.

It appends that I run the workflow twice and the body wasn't updated of the second run.

It's currently configured like so:

      - name: Create release
        if: github.event_name == 'push'
        uses: softprops/action-gh-release@c9b46fe7aad9f02afd89b12450b780f52dacfb2d
        with:
          draft: true
          body_path: release-summary.md
          name: Release v${{ needs.version.outputs.full }}
          tag_name: v${{ needs.version.outputs.full }}
          files: foobar.md
          fail_on_unmatched_files: true
          generate_release_notes: false
        timeout-minutes: 5

Using body

I've also tried to use body instead of body_path with no luck, the body of the release is still not updated.

      - name: Create release
        if: github.event_name == 'push'
        uses: softprops/action-gh-release@c9b46fe7aad9f02afd89b12450b780f52dacfb2d
        with:
          draft: true
          body: ${{ steps.summary.outputs.output }} 
          name: Release v${{ needs.version.outputs.full }}
          tag_name: v${{ needs.version.outputs.full }}
          files: foobar.md
          fail_on_unmatched_files: true
          generate_release_notes: false
        timeout-minutes: 5

What I'm expected

I would expect that the body is updated.
@FirelightFlagboy FirelightFlagboy changed the title The body of a release wasn't overwritten with the content of the file provided with body_path The body of a release is overwritten with the content of body_path or body Jun 8, 2023
@FirelightFlagboy FirelightFlagboy linked a pull request Jun 14, 2023 that will close this issue
Open
@FirelightFlagboy
Copy link
Author

I've done some testing on my side, I've created a small repo for that https://github.com/FirelightFlagboy/action-gh-release-test

This was referenced Feb 26, 2024
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing update release body FirelightFlagboy/action-gh-release
1 participant
@FirelightFlagboy