Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions user despite custom token #141

Closed
casperdcl opened this issue Aug 9, 2021 · 2 comments
Closed

github-actions user despite custom token #141

casperdcl opened this issue Aug 9, 2021 · 2 comments

Comments

@casperdcl
Copy link

casperdcl commented Aug 9, 2021

Since late July/early August, using a custom token: $MYBOT_TOKEN no longer results in "mybot released this X days ago." Instead, it incorrectly says "github-actions released this X days ago." Example: https://github.com/iterative/shtab/releases

Is there a problem with action-gh-release? Or is it another accidental breaking change GH made (to be reported at https://github.community)?

@softprops
Copy link
Owner

Hi there. I see your last release was 4 days ago and your using an env var for the token

You were likely caught in a breaking change that was fixed just yesterday

https://github.com/softprops/action-gh-release/releases/tag/v0.1.8

the breaking change was a merge of a pr that introduced resolving the token from an input falling back on an env var. the breaking change was that the input was declared with a default of the actions provided token which always exists meaning the env var would never get used. The fix for backwards compat was to swap the resolution order to look for the env var and then the input

@casperdcl
Copy link
Author

Ah related #132, fixed by #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants