Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: default maxRetries to a small number instead of infinity #83

Open
alexkrolick opened this issue Jun 27, 2019 · 1 comment

Comments

@alexkrolick
Copy link

alexkrolick commented Jun 27, 2019

Due to the issue with Axios 0.19, clients may have gotten hit with infinite retries unexpectedly. The default could be made safer so this doesn't happen.

#59 (comment)

Proposal: can the defaults be changed to "fail closed" (not retry at all or retry with a low maximum count) instead of infinitely retrying?


EDIT: it looks like there is an attempt to default to 3 here: https://github.com/softonic/axios-retry/blob/master/es/index.js#L189; not sure if that means the bug is due to something more complex or what. Hope there's some tweak that would make it work.

@ToeFungi
Copy link

@alexkrolick yea it would appear that default retry limit is not being set to 3 correctly for Axios 0.19

I had to downgrade Axios to 0.18.0 and used axios-retry 3.1.1 and the retry limit appears to be working correctly again. Not sure if it's an issue between the monitor and the chair on my side or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants