retryCondition should use promise value in return

[PeterChen1997]

I think it's better to get the control back to user, it's more flexible

[YangChen00]

@mindhells plz have a look, thx

[mindhells]

you'd need to fix the tests
can you please give a little more context?

[PeterChen1997]

The condition is that i want use Promise to control the retry result, instead of use throw error in it. It's not handy

[PeterChen1997]

The test i will have a look

[PeterChen1997]

solved, plz have a look again @mindhells

[mindhells]

I believe this relates to #190

I missing 2 things to merge this PR:

• update the docs to note retryCondition should return a boolean
• don't change behavior for those using a retryCondition that just doesn't throw: this would mean return true unless await shouldRetryOrPromise === false

WDYT?

[PeterChen1997]

Got it, i will have a look on it

[PeterChen1997]

@mindhells Done, have i got the point?

[mindhells]

@mindhells Done, have i got the point?

Yes! I think so
thanks a lot
I'm going to merge a create a new release

[mindhells]

v3.2.5 published!