Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy actor is not terminated on close #939

Closed
qwwdfsad opened this issue Jan 16, 2019 · 0 comments · May be fixed by softagram/kotlinx.coroutines#6
Closed

Lazy actor is not terminated on close #939

qwwdfsad opened this issue Jan 16, 2019 · 0 comments · May be fixed by softagram/kotlinx.coroutines#6
Assignees
@qwwdfsad
Labels
bug

Comments

@qwwdfsad
Copy link
Contributor

Reproducer:

val job = launch {
  val actor = actor<Int>(start = CoroutineStart.LAZY) {}
  actor.close()
}

job.join()
@qwwdfsad qwwdfsad added the bug label Jan 16, 2019
@qwwdfsad qwwdfsad self-assigned this Jan 16, 2019
qwwdfsad added a commit that referenced this issue Jan 17, 2019
@qwwdfsad
Start lazy actor when calling close
36e9917 
Rationale:
While it is possible to atomically transition state machine to "completed", it has multiple caveats:
  * It breaks intuition that "close" allows actors to process remaining messages and call its body
  * It introduces one more internal API dependency
  * It makes behaviour of non-lazy and lazy actors inconsistent

Fixes #939
@qwwdfsad qwwdfsad mentioned this issue Jan 17, 2019
Merged
@villelaitila villelaitila mentioned this issue Jan 28, 2019
Open
elizarov pushed a commit that referenced this issue Feb 6, 2019
@qwwdfsad @elizarov
Start lazy actor when calling close
6543988 
Rationale:
While it is possible to atomically transition state machine to "completed", it has multiple caveats:
  * It breaks intuition that "close" allows actors to process remaining messages and call its body
  * It introduces one more internal API dependency
  * It makes behaviour of non-lazy and lazy actors inconsistent

Fixes #939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwwdfsad qwwdfsad

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Start lazy actor when calling close softagram/kotlinx.coroutines
1 participant
@qwwdfsad