Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring which connection headers are exposed #198

Closed
mitar opened this issue Apr 18, 2016 · 3 comments
Closed

Allow configuring which connection headers are exposed #198

mitar opened this issue Apr 18, 2016 · 3 comments

Comments

@mitar
Copy link
Contributor

mitar commented Apr 18, 2016

Currently, there is a hard-coded list of headers which are available on the connection. I think this should be configurable. Or at least all x- prefixed headers should be available.

I am trying to use Meteor with Sandstorm and the latter sends quite some information in proxied requests in headers with x- prefix. Currently all that is not accessible. :-(

@prawnsalad
Copy link

I also need this as I'm trying to read cookies and custom headers. What is the rational for having a whitelist of cookies?

@mitar
Copy link
Contributor Author

mitar commented Apr 21, 2016

You can read here about cookies: https://github.com/sockjs/sockjs-node#authorisation

@kentonv
Copy link

kentonv commented May 5, 2016

The problem with cookies also applies to the X-Sandstorm headers. The fact that they are added server-side by a reverse proxy does not make them any more trustworthy than cookies. In fact, the proxy derives these headers from a cookie. You should not whitelist them.

@mitar mitar closed this as completed May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants