Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falcon serve on blank rails app with ruby 3.0.0 fails #138

Closed
scally opened this issue Jan 13, 2021 · 3 comments
Closed

falcon serve on blank rails app with ruby 3.0.0 fails #138

scally opened this issue Jan 13, 2021 · 3 comments

Comments

@scally
Copy link

scally commented Jan 13, 2021

/Users/sean/.rvm/gems/ruby-3.0.0/gems/railties-6.1.1/lib/rails/initializable.rb:60 in `run_initializers'
/Users/sean/.rvm/gems/ruby-3.0.0rve.rb:60 in `load_app'
 /Users/sean/.rvm/gems/ruby-3.0.0/gems/falcon-0.37.2/lib/falcon/controller/serve.rb:89 in `block (2 levels) in setup'
/Users/sean/.rvm/gems/ruby-3.0.0/gems/async-1.28.3/lib/async/task.rb:265 in `block in make_fiber'
Caused by TypeError: nil can't be coerced into Float
→ /Users/sean/.rvm/gems/ruby-3.0.0/gems/timers-4.3.2/lib/timers/timer.rb:103 in `+'

A blank app will boot with ruby 3.0 and rails 6.1 using rails s. Removing puma and adding falcon to the gem file and then running falcon serve results in this error.

@the-spectator
Copy link

I can reproduce the issue on my system. I tracked the error in the listen gem, method wait_for_state is passing timeout as nil, due to incorrect passing of arguments.

Relevant Code: https://github.com/guard/listen/blob/f0572f7bbca48fb832d4ada5a61d729db0d20a88/lib/listen/event/loop.rb#L55-L59

System configuration

ruby version: 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-linux]
rails: 6.1.1
falcon: 0.37.2
async: 1.28.3
listen: 3.4.0

@the-spectator
Copy link

I have created guard/listen#529 to resolve this issue on listen master.

@scally
Copy link
Author

scally commented Jan 14, 2021

confirmed, bumping to latest listen solves this problem

@scally scally closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants