-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async::Container::Process, SystemStackError: stack level too deep #157
Comments
Can you try updating to the latest version of protocol-http as I believe we addressed this issue. |
Ah yes, that's the other report I found. The above error is with:
|
So, a weird (possibly related behaviour) I'm seeing is that when a request is processed via Update with some code Sync do
endpoint = Async::HTTP::Endpoint.parse("http://hostname:80")
client = Async::HTTP::Client.new(endpoint)
client.get("/")
end Results in the following error, which is slightly different than the one above: /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/activesupport-7.1.3.2/lib/active_support/core_ext/object/instance_variables.rb:15:in `to_h': stack level too deep (SystemStackError)
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/activesupport-7.1.3.2/lib/active_support/core_ext/object/instance_variables.rb:15:in `instance_values'
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/activesupport-7.1.3.2/lib/active_support/core_ext/object/json.rb:63:in `as_json'
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/activesupport-7.1.3.2/lib/active_support/core_ext/object/json.rb:188:in `block in as_json'
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/activesupport-7.1.3.2/lib/active_support/core_ext/object/json.rb:187:in `each'
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/activesupport-7.1.3.2/lib/active_support/core_ext/object/json.rb:187:in `as_json'
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/activesupport-7.1.3.2/lib/active_support/core_ext/object/json.rb:63:in `as_json'
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/activesupport-7.1.3.2/lib/active_support/core_ext/object/json.rb:188:in `block in as_json'
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/activesupport-7.1.3.2/lib/active_support/core_ext/object/json.rb:187:in `each'
... 1042 levels...
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/async-pool-0.4.0/lib/async/pool/controller.rb:210:in `ensure in block in start_gardener'
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/async-pool-0.4.0/lib/async/pool/controller.rb:210:in `block in start_gardener'
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/async-2.10.2/lib/async/task.rb:163:in `block in run'
from /Users/travisbell/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/async-2.10.2/lib/async/task.rb:376:in `block in schedule' This request on the other hand returns successfully, with no error: Sync do
endpoint = Async::HTTP::Endpoint.parse("https://hostname:443")
client = Async::HTTP::Client.new(endpoint)
client.get("/")
end Again, sorry about this not being in |
Okay, let me take a look. |
Are you able to make a complete reproduction for me, as I can't get it to fail: Example code:
Output:
|
Ah, I figured it out... hold on. |
Okay, the first part, updating |
Next set of fixes: 8afd1f1 |
Okay, I've released updates to both After updating the gems, can you test it again? Thanks. |
Yup, looking good. I no longer see the error. 馃憦馃徏 Thanks a ton for the quick turnaround, truly legendary. |
I blame Rails for this - monkey patching the core classes (including |
Hey Sam,
Sorry for just dumping this report in the
async
library. I think maybe it's technically a anasync-pool
(?) bug. Not 100% sure. There's so many repos now... 馃槈 Anywho, I've been playingasync-http
and when ctrl-c'ing an instance of Falcon, this gets dumped to the terminal:I saw another bug you fixed somewhere for this, so I suspect you know what's happening.
Thanks as always.
The text was updated successfully, but these errors were encountered: