Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme.md #3759

Merged
merged 1 commit into from Jan 17, 2021
Merged

Updated Readme.md #3759

merged 1 commit into from Jan 17, 2021

Conversation

hamdibayhan
Copy link
Contributor

@hamdibayhan hamdibayhan commented Jan 16, 2021

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

Link goes to https://github.com/socketio/socket.io-client/blob/master/docs/API.md#new-managerurl-options

New behavior

Link goes to https://socket.io/docs/v3/client-api/#new-Manager-url-options

Other information (e.g. related issues)

Fixed broken link in Auto-reconnection support section.

Fixed broken link in Auto-reconnection support section.
@Prashoon123
Copy link
Contributor

@hamdibayhan even I think this PR will be very helpful because broken links are never good. Thank you for fixing this issue. I think so your PR will be merged!!

@darrachequesne darrachequesne merged commit f34cfca into socketio:master Jan 17, 2021
@darrachequesne
Copy link
Member

Good catch, thanks!

dzad pushed a commit to dzad/socket.io that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants