fix(typings): expose additional needed types #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@types/socket.io used to export these
|
@AviVahl thanks! |
|
Any ideas why I am getting this error when trying to import
I am not using typescript and only doing the import for JSDoc type hints. Last version I tried was 3.0.2 |
5 tasks
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
@types/socket.io used to export these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
Needed interfaces/types are not exposed.
@types/socket.ioused to export these.New behaviour
Exported needed types.
Other information (e.g. related issues)
Noticed while upgrading. Will create a similar PR to
socket.io-client.May want to consider adding the type modifier to the export, so that the actual abstractions won't be exposed. Downside: it will make the
.d.tsonly compatible with ts@2.8+.Off-topic
You using TypeScript and publishing built-in
.d.tsis awesome.