Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add a 'binary' flag #3185

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

darrachequesne
Copy link
Member

So that the call to the has-binary method can be skipped. Usage:

// with binary data
socket.binary(true).emit("binary", obj);

// without binary data
socket.binary(false).emit("string", obj);

// call to hasBin
socket.emit("guess", obj);

From #2838.

So that the call to the `has-binary` method can be skipped. Usage:

```
// with binary data
socket.binary(true).emit("binary", obj);

// without binary data
socket.binary(false).emit("string", obj);

// call to hasBin
socket.emit("guess", obj);
```
@darrachequesne darrachequesne merged commit f48a06c into socketio:master Feb 28, 2018
@darrachequesne darrachequesne deleted the feat/binary-flag branch February 28, 2018 22:00
@darrachequesne darrachequesne added this to the 2.1.0 milestone Feb 28, 2018
dzad pushed a commit to dzad/socket.io that referenced this pull request May 29, 2023
So that the call to the `has-binary` method can be skipped. Usage:

```
// with binary data
socket.binary(true).emit("binary", obj);

// without binary data
socket.binary(false).emit("string", obj);

// call to hasBin
socket.emit("guess", obj);
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant