Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Delivery tutorial is missing things #425

Open
mikebourbeauart opened this issue Nov 17, 2023 · 2 comments
Open

Server Delivery tutorial is missing things #425

mikebourbeauart opened this issue Nov 17, 2023 · 2 comments

Comments

@mikebourbeauart
Copy link

https://socket.io/docs/v4/tutorial/step-7

This tutorial doesn't provide code to create the "Disconnect" button in order to test things out. It's simple enough to get past that part, but it's not clear how I'd hook this up to test out disconnection.

darrachequesne added a commit that referenced this issue Nov 17, 2023
@darrachequesne
Copy link
Member

H! Thanks a lot for the feedback 👍

I've added the code for the "Disconnect" button in the tutorial: https://socket.io/docs/v4/tutorial/step-6

@mikebourbeauart
Copy link
Author

It works, thank you!

I do have 1 suggestion though: From what I've seen in the tutorial so far the code isn't usually tucked away inside a collapsed admonition. Since it's required code for the next sections it probably shouldn't be collapsed by default (so people don't accidentally miss it) or maybe it's taken out of the admonition since it seems like most code isn't within one to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants