Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs - Client API - Update description about io(url) #140

Closed
wants to merge 1 commit into from
Closed

Docs - Client API - Update description about io(url) #140

wants to merge 1 commit into from

Conversation

sandrina-p
Copy link
Contributor

Closes #139

@sandrina-p
Docs - Client API - io.protocol
5f981d9 
Change `window.location` to `window.location.host`. If `io(window.location)` is started, it works, but then if we pass `options`, those are ignored.
@snyk-bot snyk-bot mentioned this pull request May 24, 2021
Open
@baby636 baby636 mentioned this pull request May 14, 2022
Open
@darrachequesne darrachequesne changed the base branch from master to main November 25, 2022 09:04
darrachequesne pushed a commit that referenced this pull request Nov 25, 2022
@sandrina-p @darrachequesne
docs: fix default url in client initialization (#140)
4cb010f 
Change `window.location` to `window.location.host`. If
`io(window.location)` is started, it works, but then if we pass
`options`, those are ignored.

Related:

- #139
- #343
@darrachequesne
Copy link
Member

Merged as 4cb010f. Thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: client API - io() returns 400 BAD REQUEST when passing window.location
2 participants
@sandrina-p @darrachequesne