Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to fetchSockets that returns results even if some nodes didn't respond #88

Open
timsauvageot opened this issue Apr 12, 2024 · 0 comments

Comments

@timsauvageot
Copy link

Hey there,

the current implementation of fetchSockets in ClusterAdapterWithHeartbeat only resolves if a response was received from all cluster nodes. In some situations this isn't needed and an optimistic response would suffice (i.e. return all responses of nodes that are alive).
Two options I can think of to do this would be to add an optional optimistic flag to the fetchSockets method or add it as parameter to the cluster config. The value would default to false for backwards compatibility. I can open a PR and implement it if you don't see any issues with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant