this.pingIntervalTimer.refresh is not a function

[JeffWinder]

Describe the bug
socket.js:108 Uncaught TypeError: this.pingIntervalTimer.refresh is not a function
at Socket.onPacket (socket.js:108)

To Reproduce
engine.io: 6.1.0
engine.io-client: 6.1.1
socket.io: 4.4.0
socket.io-client: 4.4.0

Platform:

• OS: windows 10

Additional context
Adding
console.log(typeof this.pingIntervalTimer)
just before line 108 shows that it's a number, not a Timer.

this.pingIntervalTime.refresh()
was added here it seems:
37474c7

[darrachequesne]

Which version of Node.js are you using? The refresh method was added in v10.2.0.

[JeffWinder]

Yes I saw that: https://nodejs.org/api/timers.html#timeoutrefresh
I've tried with 16.9.1, 16.11.1 and 16.13.0

[JeffWinder]

And now I'm suddenly getting the type of Timer back instead of number, for all three node versions mentioned above, no idea what changed on my end. As if it was seen as the javascriptsetTimout before. So now the error is gone.

[JeffWinder]

Okay, I think I see what happened. When I wanted to console.log setTimeout in socket.js, VS Code added
const { setTimeout } = require('timers'); for me when I typed it.
This makes the error go away. So it looks like when leaving out this import javascript's setTimeout is being used, resulting in the error?

[darrachequesne]

Were you able to find a solution? Is there something we can fix on our end?

[JeffWinder]

I think it would be best to explicitly import setTimeout and clearTimeout from Node's timers module, by adding this in lib/socket.ts:
import { setTimeout, clearTimeout } from "timers";
That would make sure compilers don't mistaken those functions for javascript timers, of which setTimeout doesn't have a refresh function. Hence the error in my scenario.

I can also make a PR for that tomorrow if you like.

[JeffWinder]

Here's the PR: #632

[darrachequesne]

Closed by #632.