Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change URL max length to 8000 or at least add option/config #715

Open
tolu opened this issue Nov 29, 2023 · 0 comments
Open

Change URL max length to 8000 or at least add option/config #715

tolu opened this issue Nov 29, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@tolu
Copy link

tolu commented Nov 29, 2023

Is your feature request related to a problem? Please describe.

The newly introduced limit on 2000 characters for URL's is breaking our implementation since we pass JWT's that are generally large as query parameters... If that is a good or bad idea, let's leave that aside. It's at least a solution we've had in production for at least 6 years.

Describe the solution you'd like

Could the limit be raised to 8000?

From https://www.rfc-editor.org/rfc/rfc9110#section-4.1-5

It is RECOMMENDED that all senders and recipients support, at a minimum, URIs with lengths of 8000 octets in protocol elements. Note that this implies some structures and on-wire representations (for example, the request line in HTTP/1.1) will necessarily be larger in some cases.

Or at least be controlled via an optional parameter/config or some such in order to at least not break in the presence of fully valid URL's. 🙏

@tolu tolu added the enhancement New feature or request label Nov 29, 2023
darrachequesne added a commit that referenced this issue Apr 23, 2024
The previous limit of 2000 characters was a bit too low in certain cases.

From https://www.rfc-editor.org/rfc/rfc9110#section-4.1-5

> It is RECOMMENDED that all senders and recipients support, at a minimum, URIs with lengths of 8000 octets in protocol elements.

Related: #715

See also: 707597d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant